-1 We have been "encouraging" people to set their editors for nearly two decades and it just doesn't work. Cheers Nigel --- Nigel W. Moriarty Building 33R0349, Molecular Biophysics and Integrated Bioimaging Lawrence Berkeley National Laboratory Berkeley, CA 94720-8235 Phone : 510-486-5709 Email : [email protected] Fax : 510-486-5909 Web : CCI.LBL.gov On Wed, Aug 14, 2019 at 2:44 AM Luc Bourhis wrote:

...

On 14 Aug 2019, at 10:56, "[email protected]" < [email protected]> wrote:

3) If finding clutter is so important, why not add an optional pre-commit hook to help prevent "clutter" ever being committed in the first place?

+1

That would encourage people to properly set up their editor to never get trailing spaces in the first place!

_______________________________________________ cctbxbb mailing list [email protected] http://phenix-online.org/mailman/listinfo/cctbxbb

I meant to say once a week, which is what we do with black formatting in DIALS, but the principle is the same. Dr Richard Gildea Data Analysis Scientist Tel: +441235 77 8078 Diamond Light Source Ltd. Diamond House Harwell Science & Innovation Campus Didcot Oxfordshire OX11 0DE ________________________________ From: Gildea, Richard (DLSLtd,RAL,LSCI) Sent: 14 August 2019 17:00:02 To: cctbx mailing list Subject: Re: [cctbxbb] cctbx azure pipelines skipping tests if clutter Editors won't catch unused imports... If "encouraging" people to set their editors to strip trailing whitespace hasn't worked for nearly 20 years, why not just setup a job to automatically strip trailing whitespace (say) once a month? Dr Richard Gildea Data Analysis Scientist Tel: +441235 77 8078 Diamond Light Source Ltd. Diamond House Harwell Science & Innovation Campus Didcot Oxfordshire OX11 0DE ________________________________ From: [email protected] on behalf of Nigel Moriarty Sent: 14 August 2019 16:50:17 To: cctbx mailing list Subject: Re: [cctbxbb] cctbx azure pipelines skipping tests if clutter -1 We have been "encouraging" people to set their editors for nearly two decades and it just doesn't work. Cheers Nigel --- Nigel W. Moriarty Building 33R0349, Molecular Biophysics and Integrated Bioimaging Lawrence Berkeley National Laboratory Berkeley, CA 94720-8235 Phone : 510-486-5709 Email : [email protected] Fax : 510-486-5909 Web : CCI.LBL.govhttp://CCI.LBL.gov On Wed, Aug 14, 2019 at 2:44 AM Luc Bourhis mailto:[email protected]> wrote:

On 14 Aug 2019, at 10:56, "[email protected]mailto:[email protected]" mailto:[email protected]> wrote:

3) If finding clutter is so important, why not add an optional pre-commit hook to help prevent "clutter" ever being committed in the first place?

+1 That would encourage people to properly set up their editor to never get trailing spaces in the first place! _______________________________________________ cctbxbb mailing list [email protected]mailto:[email protected] http://phenix-online.org/mailman/listinfo/cctbxbb -- This e-mail and any attachments may contain confidential, copyright and or privileged material, and are for the use of the intended addressee only. If you are not the intended addressee or an authorised recipient of the addressee please notify us of receipt by returning the e-mail and do not use, copy, retain, distribute or disclose the information in or attached to the e-mail. Any opinions expressed within this e-mail are those of the individual and not necessarily of Diamond Light Source Ltd. Diamond Light Source Ltd. cannot guarantee that this e-mail or any attachments are free from viruses and we cannot accept liability for any damage which you may sustain as a result of software viruses which may be transmitted in or with the message. Diamond Light Source Limited (company no. 4375679). Registered in England and Wales with its registered office at Diamond House, Harwell Science and Innovation Campus, Didcot, Oxfordshire, OX11 0DE, United Kingdom