Hi guys, there was big change in dxtbx/model/panel.h on the 30th of October (r18499) and apparently the != operator became recursive by calling itself rather than the == operator (line 378) - whoever is responsible - please check/fix, Cheers, Oleg.
Hi Oleg, That was probably James Parkhurst's change and he's off on vacation this week: I will look at it. What platform are you using to build? Thanks, Graeme From: [email protected] [mailto:[email protected]] On Behalf Of Oleg Dolomanov Sent: 04 November 2013 16:21 To: [email protected] Subject: [cctbxbb] compiler warning in dxtbx Hi guys, there was big change in dxtbx/model/panel.h on the 30th of October (r18499) and apparently the != operator became recursive by calling itself rather than the == operator (line 378) - whoever is responsible - please check/fix, Cheers, Oleg. -- This e-mail and any attachments may contain confidential, copyright and or privileged material, and are for the use of the intended addressee only. If you are not the intended addressee or an authorised recipient of the addressee please notify us of receipt by returning the e-mail and do not use, copy, retain, distribute or disclose the information in or attached to the e-mail. Any opinions expressed within this e-mail are those of the individual and not necessarily of Diamond Light Source Ltd. Diamond Light Source Ltd. cannot guarantee that this e-mail or any attachments are free from viruses and we cannot accept liability for any damage which you may sustain as a result of software viruses which may be transmitted in or with the message. Diamond Light Source Limited (company no. 4375679). Registered in England and Wales with its registered office at Diamond House, Harwell Science and Innovation Campus, Didcot, Oxfordshire, OX11 0DE, United Kingdom
Hi Graeme, The platform does not matter - it is a logical error... But CL on Windows prints a warning. Cheers,o From: [email protected] To: [email protected] Date: Mon, 4 Nov 2013 16:22:38 +0000 Subject: Re: [cctbxbb] compiler warning in dxtbx Hi Oleg, That was probably James Parkhurst’s change and he’s off on vacation this week: I will look at it. What platform are you using to build? Thanks, Graeme From: [email protected] [mailto:[email protected]] On Behalf Of Oleg Dolomanov Sent: 04 November 2013 16:21 To: [email protected] Subject: [cctbxbb] compiler warning in dxtbx Hi guys, there was big change in dxtbx/model/panel.h on the 30th of October (r18499) and apparently the != operator became recursive by calling itself rather than the == operator (line 378) - whoever is responsible - please check/fix, Cheers, Oleg. -- This e-mail and any attachments may contain confidential, copyright and or privileged material, and are for the use of the intended addressee only. If you are not the intended addressee or an authorised recipient of the addressee please notify us of receipt by returning the e-mail and do not use, copy, retain, distribute or disclose the information in or attached to the e-mail. Any opinions expressed within this e-mail are those of the individual and not necessarily of Diamond Light Source Ltd. Diamond Light Source Ltd. cannot guarantee that this e-mail or any attachments are free from viruses and we cannot accept liability for any damage which you may sustain as a result of software viruses which may be transmitted in or with the message. Diamond Light Source Limited (company no. 4375679). Registered in England and Wales with its registered office at Diamond House, Harwell Science and Innovation Campus, Didcot, Oxfordshire, OX11 0DE, United Kingdom _______________________________________________ cctbxbb mailing list [email protected] http://phenix-online.org/mailman/listinfo/cctbxbb
Reason I ask is I got no warning...
I will dig out windows builder...
Thanks Graeme
Sent from Samsung Mobile
Oleg Dolomanov
[gw56@ws133 model]$ svn diff Index: panel.h =================================================================== --- panel.h (revision 18525) +++ panel.h (working copy) @@ -375,7 +375,7 @@ /** @returns True/False this is not the same as the other */ bool operator!=(const PanelBase &other) const { - return *this != other; + return !(*this == other); } protected: built fine for me on RHEL6, assume that this is a sound definition as not recursive... [gw56@ws133 model]$ svn commit -m "Fix of panel to prevent recursive definition" Sending model/panel.h Transmitting file data . Committed revision 18527. Cheerio, Graeme From: [email protected] [mailto:[email protected]] On Behalf Of Oleg Dolomanov Sent: 04 November 2013 16:21 To: [email protected] Subject: [cctbxbb] compiler warning in dxtbx Hi guys, there was big change in dxtbx/model/panel.h on the 30th of October (r18499) and apparently the != operator became recursive by calling itself rather than the == operator (line 378) - whoever is responsible - please check/fix, Cheers, Oleg. -- This e-mail and any attachments may contain confidential, copyright and or privileged material, and are for the use of the intended addressee only. If you are not the intended addressee or an authorised recipient of the addressee please notify us of receipt by returning the e-mail and do not use, copy, retain, distribute or disclose the information in or attached to the e-mail. Any opinions expressed within this e-mail are those of the individual and not necessarily of Diamond Light Source Ltd. Diamond Light Source Ltd. cannot guarantee that this e-mail or any attachments are free from viruses and we cannot accept liability for any damage which you may sustain as a result of software viruses which may be transmitted in or with the message. Diamond Light Source Limited (company no. 4375679). Registered in England and Wales with its registered office at Diamond House, Harwell Science and Innovation Campus, Didcot, Oxfordshire, OX11 0DE, United Kingdom
It appears to be corrected, Cheers, Oleg. From: [email protected] To: [email protected] Date: Mon, 4 Nov 2013 16:28:47 +0000 Subject: Re: [cctbxbb] compiler warning in dxtbx [gw56@ws133 model]$ svn diff Index: panel.h =================================================================== --- panel.h (revision 18525) +++ panel.h (working copy) @@ -375,7 +375,7 @@ /** @returns True/False this is not the same as the other */ bool operator!=(const PanelBase &other) const { - return *this != other; + return !(*this == other); } protected: built fine for me on RHEL6, assume that this is a sound definition as not recursive… [gw56@ws133 model]$ svn commit -m "Fix of panel to prevent recursive definition" Sending model/panel.h Transmitting file data . Committed revision 18527. Cheerio, Graeme From: [email protected] [mailto:[email protected]] On Behalf Of Oleg Dolomanov Sent: 04 November 2013 16:21 To: [email protected] Subject: [cctbxbb] compiler warning in dxtbx Hi guys, there was big change in dxtbx/model/panel.h on the 30th of October (r18499) and apparently the != operator became recursive by calling itself rather than the == operator (line 378) - whoever is responsible - please check/fix, Cheers, Oleg. -- This e-mail and any attachments may contain confidential, copyright and or privileged material, and are for the use of the intended addressee only. If you are not the intended addressee or an authorised recipient of the addressee please notify us of receipt by returning the e-mail and do not use, copy, retain, distribute or disclose the information in or attached to the e-mail. Any opinions expressed within this e-mail are those of the individual and not necessarily of Diamond Light Source Ltd. Diamond Light Source Ltd. cannot guarantee that this e-mail or any attachments are free from viruses and we cannot accept liability for any damage which you may sustain as a result of software viruses which may be transmitted in or with the message. Diamond Light Source Limited (company no. 4375679). Registered in England and Wales with its registered office at Diamond House, Harwell Science and Innovation Campus, Didcot, Oxfordshire, OX11 0DE, United Kingdom _______________________________________________ cctbxbb mailing list [email protected] http://phenix-online.org/mailman/listinfo/cctbxbb
Doesn't line 279 also have the same problem?
/** @returns True/False This and the other frame are different */
bool operator!=(const PanelFrame &other) const {
return *this != other;
}
Cheers,
Richard
On 4 Nov 2013, at 16:35, Oleg Dolomanov
It appears to be corrected,
Cheers, Oleg.
From: [email protected] To: [email protected] Date: Mon, 4 Nov 2013 16:28:47 +0000 Subject: Re: [cctbxbb] compiler warning in dxtbx
[gw56@ws133 model]$ svn diff Index: panel.h =================================================================== --- panel.h (revision 18525) +++ panel.h (working copy) @@ -375,7 +375,7 @@
/** @returns True/False this is not the same as the other */ bool operator!=(const PanelBase &other) const { - return *this != other; + return !(*this == other); }
protected:
built fine for me on RHEL6, assume that this is a sound definition as not recursive…
[gw56@ws133 model]$ svn commit -m "Fix of panel to prevent recursive definition" Sending model/panel.h Transmitting file data . Committed revision 18527.
Cheerio, Graeme
From: [email protected] [mailto:[email protected]] On Behalf Of Oleg Dolomanov Sent: 04 November 2013 16:21 To: [email protected] Subject: [cctbxbb] compiler warning in dxtbx
Hi guys,
there was big change in dxtbx/model/panel.h on the 30th of October (r18499) and apparently the != operator became recursive by calling itself rather than the == operator (line 378) - whoever is responsible - please check/fix,
Cheers,
Oleg.
-- This e-mail and any attachments may contain confidential, copyright and or privileged material, and are for the use of the intended addressee only. If you are not the intended addressee or an authorised recipient of the addressee please notify us of receipt by returning the e-mail and do not use, copy, retain, distribute or disclose the information in or attached to the e-mail. Any opinions expressed within this e-mail are those of the individual and not necessarily of Diamond Light Source Ltd. Diamond Light Source Ltd. cannot guarantee that this e-mail or any attachments are free from viruses and we cannot accept liability for any damage which you may sustain as a result of software viruses which may be transmitted in or with the message. Diamond Light Source Limited (company no. 4375679). Registered in England and Wales with its registered office at Diamond House, Harwell Science and Innovation Campus, Didcot, Oxfordshire, OX11 0DE, United Kingdom
_______________________________________________ cctbxbb mailing list [email protected] http://phenix-online.org/mailman/listinfo/cctbxbb _______________________________________________ cctbxbb mailing list [email protected] http://phenix-online.org/mailman/listinfo/cctbxbb
indeed - sorry that I forgot to mention,
Oleg.
From: [email protected]
Date: Mon, 4 Nov 2013 16:39:21 +0000
To: [email protected]
Subject: Re: [cctbxbb] compiler warning in dxtbx
Doesn't line 279 also have the same problem?
/** @returns True/False This and the other frame are different */ bool operator!=(const PanelFrame &other) const { return *this != other; }
Cheers,
Richard
On 4 Nov 2013, at 16:35, Oleg Dolomanov
Did you fix it?
If not please do :-)
Sent from Samsung Mobile
Richard Gildea
participants (3)
-
Graeme.Winter＠diamond.ac.uk -
Oleg Dolomanov -
Richard Gildea