Phenix dependencies in CCTBX code
Dear All, In cctbx_project/iotbx/pdb/multimer_reconstruction.py there is a dependency on Phenix from phenix.command_line.simple_ncs_from_pdb import simple_ncs_from_pdb from phenix.command_line.simple_ncs_from_pdb import ncs_master_params Please could someone remove this? I just had a look at cleaning things up so that this was encapsulated but was not obvious and figured risk of breaking was more substantial. This is breaking our nightly build tests at Diamond as we don’t check out phenix :o( Thanks Graeme -- This e-mail and any attachments may contain confidential, copyright and or privileged material, and are for the use of the intended addressee only. If you are not the intended addressee or an authorised recipient of the addressee please notify us of receipt by returning the e-mail and do not use, copy, retain, distribute or disclose the information in or attached to the e-mail. Any opinions expressed within this e-mail are those of the individual and not necessarily of Diamond Light Source Ltd. Diamond Light Source Ltd. cannot guarantee that this e-mail or any attachments are free from viruses and we cannot accept liability for any damage which you may sustain as a result of software viruses which may be transmitted in or with the message. Diamond Light Source Limited (company no. 4375679). Registered in England and Wales with its registered office at Diamond House, Harwell Science and Innovation Campus, Didcot, Oxfordshire, OX11 0DE, United Kingdom
On Sun, Jun 22, 2014 at 10:50 AM,
In cctbx_project/iotbx/pdb/multimer_reconstruction.py there is a dependency on Phenix
from phenix.command_line.simple_ncs_from_pdb import simple_ncs_from_pdb from phenix.command_line.simple_ncs_from_pdb import ncs_master_params
Please could someone remove this? I just had a look at cleaning things up so that this was encapsulated but was not obvious and figured risk of breaking was more substantial.
Sorry, this should not have happened. I've checked in a fix (I hope). The usual solution is to move such imports inline; as far as I'm concerned if this happens again you would not be out of line to do so unilaterally. This is breaking our nightly build tests at Diamond as we don’t check out
phenix :o(
It's also breaking the CCTBX-specific tests in our nightly builds, since these are deliberately run without the phenix modules. I wasn't paying attention to these yesterday, unfortunately. -Nat
participants (2)
-
Graeme.Winter@diamond.ac.uk
-
Nathaniel Echols