Re: [cctbxbb] [git/cctbx] master: use larger tolerance (0b81ca799)
Pavel,
This commit did not fix test on OS X High Sierra
libtbx.python "/Users/graeme/svn/cctbx/modules/cctbx_project/cctbx/maptbx/tst_interpolation.py" [FAIL] 1.4s
Time: 1.39
Return code: 1
OKs: 0
Standard error:
Traceback (most recent call last):
File "/Users/graeme/svn/cctbx/modules/cctbx_project/cctbx/maptbx/tst_interpolation.py", line 128, in <module>
exercise(f = f, gx = gx, gy = gy, gz = gz, function_type=function_type)
File "/Users/graeme/svn/cctbx/modules/cctbx_project/cctbx/maptbx/tst_interpolation.py", line 99, in exercise
assert approx_equal(it, 0.0, 1.e-4)
AssertionError
cheers Graeme
On 11 Feb 2018, at 00:14, CCTBX commit
Hi Graeme, thanks for the note! Let's see if the commit I just made fixes it. Let me know if it's still failing (works for me on my mac laptop and one of our linux machines). If this test becomes a notorious troublemaker I will try to re-think it. Pavel On 2/11/18 22:52, [email protected] wrote:
Pavel,
This commit did not fix test on OS X High Sierra
libtbx.python "/Users/graeme/svn/cctbx/modules/cctbx_project/cctbx/maptbx/tst_interpolation.py" [FAIL] 1.4s Time: 1.39 Return code: 1 OKs: 0 Standard error: Traceback (most recent call last): File "/Users/graeme/svn/cctbx/modules/cctbx_project/cctbx/maptbx/tst_interpolation.py", line 128, in <module> exercise(f = f, gx = gx, gy = gy, gz = gz, function_type=function_type) File "/Users/graeme/svn/cctbx/modules/cctbx_project/cctbx/maptbx/tst_interpolation.py", line 99, in exercise assert approx_equal(it, 0.0, 1.e-4) AssertionError
cheers Graeme
On 11 Feb 2018, at 00:14, CCTBX commit
mailto:[email protected]> wrote: Repository : ssh://g18-sc-serv-03.diamond.ac.uk/cctbx On branch : master
________________________________
commit 0b81ca7992f9cf7730eb007aff6e8c30bd2ba71b Author: Pavel
mailto:[email protected]> Date: Sat Feb 10 16:14:51 2018 -0800 use larger tolerance
________________________________
0b81ca7992f9cf7730eb007aff6e8c30bd2ba71b cctbx/maptbx/tst_interpolation.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/cctbx/maptbx/tst_interpolation.py b/cctbx/maptbx/tst_interpolation.py index 918ba68fd..90dec8a46 100644 --- a/cctbx/maptbx/tst_interpolation.py +++ b/cctbx/maptbx/tst_interpolation.py @@ -96,15 +96,15 @@ def exercise(f,gx,gy,gz,function_type, eps = 1.e-6): if(function_type=="L"): cntr+=1 for it in [tl,gxl,gyl,gzl, tq,gxq,gyq,gzq, tt,gxt,gyt,gzt]: - assert approx_equal(it, 0.0) + assert approx_equal(it, 0.0, 1.e-4) if(function_type=="Q"): cntr+=1 for it in [tq,gxq,gyq,gzq, tt,gxt,gyt,gzt]: - assert approx_equal(it, 0.0) + assert approx_equal(it, 0.0, 1.e-4) if(function_type=="C"): cntr+=1 for it in [tt,gxt,gyt,gzt]: - assert approx_equal(it, 0.0) + assert approx_equal(it, 0.0, 1.e-4) if(abs(tl)>eps and abs(tq)>eps): assert tl >=tq if(function_type=="F"): cntr+=1
participants (2)
-
Graeme.Winter@diamond.ac.uk
-
Pavel Afonine