Re: [cctbxbb] How does Jenkins work?

27 Jul 2018

      Hi Takanori,

Still in the plane, but thanks to modern technology can look into this....

The commit ID that triggered Jenkins is shown right at the bottom of the Jenkins mails.
The latest was 71a4ab94a with an associated date of 2018-07-25 06:47:08 +0900
The branch has since been deleted, and that commit did not end up in any other remaining branch, so I can't find it in my personal repository. But I could still find it in the repository we use for notification emails.
If you run

$ git log -3 71a4ab94a

you should see this:

commit 71a4ab94a7910256c178baf2e275fd8165cd3973
Author: Takanori Nakane 
Date:   Wed Jul 25 06:47:08 2018 +0900

    dxtbx class for Rayonix MX300-HS converted into HDF5 by Cheetah pipeline at SACLA

commit 49a25028f28de33a42defabdcf055085547882d3
Author: Takanori Nakane 
Date:   Wed Jul 25 06:44:45 2018 +0900

    dxtbx class for SACLA MPCCD: supported Phase III MPCCD and compact MPCCD

commit e380927225b256a3096be2ee57aecc2a844a6b10
Author: Billy K. Poon 
Date:   Tue Jul 24 09:19:26 2018 -0700

    Table one: add options for twinning

So those two commits of yours were based on Billy's "Table one" commit. You can still find Billy's commit with that exact ID on https://github.com/cctbx/cctbx_project/commits/master
but your commits are now separated from his. So my best guess as to what happened is
* you originally made your commits on top of Billy's in a branch named dlstbx-sacla
* you either
  * pushed the dlstbx-sacla branch to Github before making your 3rd commit, or
  * rebased the dlstbx-sacla branch onto master before making your 3rd commit on master only, then inadvertently pushed both branches
* at which point Jenkins was triggered on dlstbx-sacla, seeing only the 2nd commit, and
* Jenkins fails

As Graeme implied though, there is no "penalty" associated with Jenkins failing on branches other than master.
Generally nobody (apart from yourself) will expect other branches to be stable, and they are not relevant for releases etc.
So like Graeme, I ignore any failure mails of branches that I am not personally involved in.
If a branch is part of a pull request and is supposed to be merged into master then that may be different, as at which point tests should succeed. But then the latest (and relevant) Jenkins output will be prominently visible in the Github pull request itself.

-Markus 

-----Original Message-----
From: [email protected]  On Behalf Of Takanori Nakane
Sent: 27 July 2018 17:19
To: cctbx mailing list 
Subject: Re: [cctbxbb] How does Jenkins work?

Hi Graeme,

Thank you very much for your advise.
I'll wait and see if Jenkins still complains.

Best regards,

Takanori Nakane
...
Dear Takanori
Both of our resident Git gurus are en route to Lewiston, ME so 
unlikely to pick this one up for a day or two
I would expect words like upstream synchronisation or similar will 
appear in the answer, but I would quite frankly hold tight & ignore 
the Jenkins emails - I was surprised to see it too, as I recall it 
being fixed, but figured that there was something odd happening.
Sorry I can't be more help, best wishes Graeme
...
On 27 Jul 2018, at 11:52, Takanori Nakane 
wrote:
Hi,
Why does Jenkins still run tests on my old commits on my deleted
(dxtbx-sacla) branch? The test failure is probably caused by my 
commit dc17165 but I committed a fix 5c7416b and confirmed that it 
passes the tests. So I merged my topic branch to master and deleted 
the branch from GitHub.
I know how git works but I am new to the practice in the cctbx 
repository (like using rebase instead of merge). If I am doing 
something wrong, could you please point it to me?
Best regards,
Takanori Nakane
...
<html><head></head><body><table style="width:100%; background-color:
#F59400; color: #FFF; border-radius: 0.5em; margin-bottom:
0.5em"><tr><td
style="margin: 0.5em 1.25em 0.5em 0.7em; font-weight: bold;
font-family:
sans-serif; font-size: 110%"><a
href="http://jenkins.diamond.ac.uk:8080/job/cctbx_branch_tests/145/"
style="color:#FFF; text-decoration: none"><big>Build CCTBX Branch 
Tests
is
unstable</big></a></td></tr></table><br/><table style="width:100%;
background-color: #F59400; color: #FFF; border-radius: 0.5em;
margin-bottom: 0.5em"><tr><td style="margin: 0.5em 1.25em 0.5em 
0.7em;
font-weight: bold; font-family: sans-serif; font-size: 110%"><a 
href="http://jenkins.diamond.ac.uk:8080/job/cctbx_branch_tests/145/testReport"
style="color:#FFF; text-decoration: none">3 out of 940 tests failed
(132
skipped)</a></td></tr></table><table style="margin: 0.5em 0 1em 
2em"><tr><td><pre style="font-size:80%">3 tests failed.
FAILED:
dxtbx.build_dials.modules.cctbx_project.dxtbx.tests.test_regression_
images.test_no_multiple_format_understanding[SACLA_MPCCD_Cheetah/run
266702-0-subset.h5]
Error Message:
exit code 1
Stack Trace:
FAILED:
dxtbx.build_dials.modules.cctbx_project.dxtbx.tests.test_regression_
images.test_no_multiple_format_understanding[putative_imgCIF_HDF5_ma
pping/minicbf.h5]
Error Message:
exit code 1
Stack Trace:
FAILED:
dxtbx.build_dials.modules.cctbx_project.dxtbx.tests.test_regression_
images.test_no_multiple_format_understanding[putative_imgCIF_HDF5_ma
pping/X4_wide_M1S4_1.nxs]
Error Message:
exit code 1
Stack Trace:
</pre></td></tr></table><table style="width:100%; background-color:
#F59400; color: #FFF; border-radius: 0.5em; margin-bottom:
0.5em"><tr><td
style="margin: 0.5em 1.25em 0.5em 0.7em; font-weight: bold;
font-family:
sans-serif; font-size: 110%">Changes since the last successful 
build</td></tr></table><table style="margin: 0.5em 0 1em 
2em"><tr><td><table style="padding: 0.1em 0.4em; background-color:
#F59400; color:#fff"><tr><td>145</td></tr></table></td><td>No 
changes </td></tr></table>
http://phenix-online.org/mailman/listinfo/cctbxbb
--
This e-mail and any attachments may contain confidential, copyright 
and or privileged material, and are for the use of the intended addressee only.
If you are not the intended addressee or an authorised recipient of 
the addressee please notify us of receipt by returning the e-mail and 
do not use, copy, retain, distribute or disclose the information in or 
attached to the e-mail.
Any opinions expressed within this e-mail are those of the individual 
and not necessarily of Diamond Light Source Ltd.
Diamond Light Source Ltd. cannot guarantee that this e-mail or any 
attachments are free from viruses and we cannot accept liability for 
any damage which you may sustain as a result of software viruses which 
may be transmitted in or with the message.
Diamond Light Source Limited (company no. 4375679). Registered in 
England and Wales with its registered office at Diamond House, Harwell 
Science and Innovation Campus, Didcot, Oxfordshire, OX11 0DE, United 
Kingdom
_______________________________________________
cctbxbb mailing list
[email protected]
http://phenix-online.org/mailman/listinfo/cctbxbb
_______________________________________________
cctbxbb mailing list
[email protected]
http://phenix-online.org/mailman/listinfo/cctbxbb

-- 
This e-mail and any attachments may contain confidential, copyright and or privileged material, and are for the use of the intended addressee only. If you are not the intended addressee or an authorised recipient of the addressee please notify us of receipt by returning the e-mail and do not use, copy, retain, distribute or disclose the information in or attached to the e-mail.
Any opinions expressed within this e-mail are those of the individual and not necessarily of Diamond Light Source Ltd. 
Diamond Light Source Ltd. cannot guarantee that this e-mail or any attachments are free from viruses and we cannot accept liability for any damage which you may sustain as a result of software viruses which may be transmitted in or with the message.
Diamond Light Source Limited (company no. 4375679). Registered in England and Wales with its registered office at Diamond House, Harwell Science and Innovation Campus, Didcot, Oxfordshire, OX11 0DE, United Kingdom

					 0

				 0

            Reply

                Sign in to reply online

            Use email software

            Back to the thread

            Back to the list

            Powered by HyperKitty version 1.3.9.

Re: [cctbxbb] How does Jenkins work?

markus.gerstel＠diamond.ac.uk